Add showing status for test result page and fix displaying test resul…

…t content (#34)

* Add showing status for test result page and fix displaying test result content

* Add data migration for old failed test results

Gemfile

@@ -91,3 +91,5 @@ gem 'tailwindcss-rails', '~> 2.6'
 gem 'pg', '~> 1.5'
 
 gem 'draper', '~> 4.0'
+
+gem 'data_migrate', '~> 9.4'

Gemfile.lock

@@ -105,6 +105,9 @@ GEM
       bigdecimal
       rexml
     crass (1.0.6)
+    data_migrate (9.4.0)
+      activerecord (>= 6.1)
+      railties (>= 6.1)
     database_cleaner (2.0.2)
       database_cleaner-active_record (>= 2, < 3)
     database_cleaner-active_record (2.2.0)
@@ -426,6 +429,7 @@ PLATFORMS
 DEPENDENCIES
   bootsnap
   capybara
+  data_migrate (~> 9.4)
   database_cleaner
   debug
   devise (~> 4.9)

app/controllers/test_results_controller.rb

@@ -21,10 +21,6 @@ def index
     @test_results = @test_results.where(status: params[:status]) if params[:status].present?
 
     @test_results = @test_results.decorate
-    respond_to do |format|
-      format.html { render :index }
-      format.json { render json: @test_results }
-    end
   end
 
   def show

app/decorators/test_result_decorator.rb

@@ -10,4 +10,16 @@ def assertions_state
 
     'failed'
   end
+
+  def content
+    return '' if object.pending?
+
+    return JSON.parse(object.result).dig('error', 'message') if object.failed?
+
+    return JSON.parse(object.result).dig('choices', 0, 'message', 'content') if object.model_version.executor_type == 'openai'
+
+    JSON.parse(object.result)['content'] if object.completed?
+  rescue StandardError
+    ''
+  end
 end

app/jobs/test_model_version_run_job.rb

@@ -28,7 +28,7 @@ def generate_assertion_results
     test_run = test_model_version_run.test_run
 
     test_run.assertions.each do |assertion|
-      state = CheckAssertion.new(assertion).call(test_result.content)
+      state = CheckAssertion.new(assertion).call(test_result.decorate.content)
 
       test_result.assertion_results.create(assertion:, state:)
     end

app/models/test_result.rb

@@ -9,21 +9,4 @@ class TestResult < ApplicationRecord
   delegate :model_version, to: :test_model_version_run
 
   default_scope { order(id: :desc) }
-
-  def as_json(options = {})
-    options[:methods] ||= [:content]
-    super
-  end
-
-  def content
-    return '' if pending?
-
-    return JSON.parse(result).dig('error', 'message') if failed?
-
-    return JSON.parse(result).dig('choices', 0, 'message', 'content') if model_version.executor_type == 'openai'
-
-    JSON.parse(result)['content'] if completed?
-  rescue StandardError
-    ''
-  end
 end

app/services/executors/base.rb

@@ -24,7 +24,7 @@ def call(prompt)
 
       { status: :failed, result: response.body }
     rescue StandardError => e
-      { status: :failed, result: e.message }
+      { status: :failed, result: { error: { message: e.message } }.to_json }
     end
   end
 end

app/views/test_results/_test_result.json.jbuilder

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+json.extract! test_result, :id, :result, :content, :time, :rating, :status, :created_at, :updated_at
+json.url test_result_url(test_result, format: :json)

app/views/test_results/index.json.jbuilder

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+json.array! @test_results, partial: 'test_results/test_result', as: :test_result

app/views/test_results/show.html.erb

@@ -9,6 +9,15 @@
     <%= @test_result.model_version.build_name %>
   </p>
 
+  <p class="my-5">
+    <strong class="font-medium mb-1">Status:</strong>
+    <span
+      class="px-2 py-1 font-semibold leading-tight rounded-full <%= define_status_class(@test_result.status) %>"
+    >
+      <%= @test_result.status.capitalize %>
+    </span>
+   </p>
+
   <strong class="font-medium mb-1">Result:</strong>
   <pre id="json-display"></pre>
   <div class="w-full w-full mx-auto mt-10 overflow-hidden rounded-lg shadow-xs">

bin/docker-entrypoint

@@ -14,5 +14,6 @@ generate_credentials() {
 generate_credentials
 
 ./bin/rails db:prepare
+./bin/rails data:migrate          
 
 exec "${@}"

db/data/20240723151844_update_result_for_failed_test_results.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+class UpdateResultForFailedTestResults < ActiveRecord::Migration[7.1]
+  TestResult = Class.new(ActiveRecord::Base)
+
+  def up
+    TestResult.where(status: 2).find_each do |test_result|
+      parsed_result = begin
+        JSON.parse(test_result.result)
+      rescue StandardError
+        nil
+      end
+
+      test_result.update(result: { error: { message: test_result.result } }.to_json) unless parsed_result.present?
+    end
+  end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
+end

db/data_schema.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+DataMigrate::Data.define(version: 20_240_723_151_844)

spec/services/executors/base_spec.rb

@@ -48,7 +48,7 @@
       end
 
       it 'returns a failed status' do
-        expect(executor.call(prompt)).to eq({ status: :failed, result: 'execution expired' })
+        expect(executor.call(prompt)).to eq({ result: { error: { message: 'execution expired' } }.to_json, status: :failed })
       end
     end
   end