task: add e2e tests for error communication #46
Merged
+328
−327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 95.59% 95.59%
=======================================
Files 9 9
Lines 1157 1157
Branches 158 158
=======================================
Hits 1106 1106
Misses 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adds e2e tests to verify error communication in the CLI, ensuring that various error scenarios return appropriate error messages to users.
Key changes:
- Added tests for API validation errors (invalid UUID)
- Added tests for version not found errors
- Added tests for missing CLI arguments
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/cli/e2e/specs/5-Application-results-access.e2e.test.ts |
Added test case to verify error handling when an invalid UUID is provided to list-run-results command |
packages/cli/e2e/specs/3-Application-execution.e2e.test.ts |
Added two test cases: one for testing error response when a non-existent application version is used, and another for testing missing CLI arguments |
ATTRIBUTIONS.md |
Auto-generated license formatting updates (reformatted license text with copyright information and line breaks) |
muhabalwan-aginx
approved these changes
Dec 3, 2025
santi698
approved these changes
Dec 4, 2025
Collaborator
santi698
left a comment
santi698
left a comment
There was a problem hiding this comment.
LGTM after fixing typo spotted by copilot code review
na66im
force-pushed
the
task/TSDK-19-add-tests-error-communication
branch
from
349c61c to
6ae4e50
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.