Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding widget to control aspect ratio of plot #1098

Merged

Conversation

AndresOrtegaGuerrero
Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero commented Jan 14, 2025

As requested by Carlo, this PR we add widget to change the width of the plots of the bandspdosplot widget.

For instance , in a 1D GNR the original
image

can be modified to
image

The same applied for the bands+pdos plot
image

The user can do modifcations to obtain
image

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.21%. Comparing base (8df45a1) to head (0d1f7d5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/common/bands_pdos/model.py 55.55% 4 Missing ⚠️
...rc/aiidalab_qe/common/bands_pdos/bandpdoswidget.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1098   +/-   ##
=======================================
  Coverage   71.21%   71.21%           
=======================================
  Files         114      114           
  Lines        7107     7128   +21     
=======================================
+ Hits         5061     5076   +15     
- Misses       2046     2052    +6     
Flag Coverage Δ
python-3.11 71.19% <71.42%> (-0.02%) ⬇️
python-3.9 71.21% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 37231de into aiidalab:main Jan 14, 2025
8 checks passed
@AndresOrtegaGuerrero AndresOrtegaGuerrero deleted the aspect_ratio_plot branch January 14, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants