Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UV_CACHE_DIR need do be the ARG for stage3 build #1099

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jan 14, 2025

I think since the folder is used for the aiida-pseudo installation workaround, this change is needed. I don't know on the github CI it does not require this change, I need this to run docker build -it in my local laptop.

@unkcpz unkcpz requested a review from superstar54 January 14, 2025 17:18
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.21%. Comparing base (8df45a1) to head (3ce9197).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   71.21%   71.21%           
=======================================
  Files         114      114           
  Lines        7107     7107           
=======================================
  Hits         5061     5061           
  Misses       2046     2046           
Flag Coverage Δ
python-3.11 71.21% <ø> (ø)
python-3.9 71.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz force-pushed the docker-build-with-arg-set branch from 3ce9197 to d2558cf Compare January 15, 2025 08:22
@unkcpz unkcpz merged commit 891d378 into main Jan 15, 2025
10 of 11 checks passed
@unkcpz unkcpz deleted the docker-build-with-arg-set branch January 15, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant