Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests for PRs from forks #780

Merged
merged 1 commit into from
Jul 29, 2024
+12 −1
Merged

Fix integration tests for PRs from forks #780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/docker-build-test-upload.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,18 @@ jobs:
- name: Run pytest for Chrome
run: pytest -sv --driver Chrome tests_integration/
env:
QE_IMAGE: ${{ env.IMAGE }}@${{ steps.build-upload.outputs.digest }}
# We'd like to identify the image by its unique digest, i.e ghcr.io/aiidalab/qe@sha256:<digest>
# but that sadly does not work when the image is loaded to Docker locally and not published on ghcr.io
# as is the case for PRs from forks. Hence this super-ugly ternary expression...
# For forks, we take the image as ghcr.io/aiidalab/qe:pr-XXX
# which is stored in the steps.meta.outputs.tags variable
QE_IMAGE: >-
${{
github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.fork &&
steps.meta.outputs.tags ||
format('{0}@{1}', env.IMAGE, steps.build-upload.outputs.imageid)
}}

- name: Upload screenshots as artifacts
if: always()
Expand Down
Loading