Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron MaxStep Widget #800

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Electron MaxStep Widget #800

merged 5 commits into from
Sep 24, 2024

Conversation

AndresOrtegaGuerrero
Copy link
Member

This PR address #798 ,
I have encounter that this limit with some materials is quite small , for example lanthanides , so is good to have this control.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@95e8f4b). Learn more about missing BASE report.
Report is 80 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #800   +/-   ##
=======================================
  Coverage        ?   68.79%           
=======================================
  Files           ?       49           
  Lines           ?     4243           
  Branches        ?        0           
=======================================
  Hits            ?     2919           
  Misses          ?     1324           
  Partials        ?        0           
Flag Coverage Δ
python-3.11 68.79% <100.00%> (?)
python-3.9 68.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikibonacci
Copy link
Member

Hi @AndresOrtegaGuerrero , LGTM!

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 6c7d6b6 into main Sep 24, 2024
12 checks passed
@AndresOrtegaGuerrero AndresOrtegaGuerrero deleted the electron_maxstep branch September 24, 2024 12:54
edan-bainglass added a commit to edan-bainglass/aiidalab-qe that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants