Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign status and results step #978

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

edan-bainglass
Copy link
Member

@edan-bainglass edan-bainglass commented Dec 16, 2024

This PR redesigns step 4 as follows:

Resolves #994
Resolves #977
Resolves #990

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 84.44444% with 49 lines in your changes missing coverage. Please review.

Project coverage is 69.05%. Comparing base (9e2f4b5) to head (09ff408).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...aiidalab_qe/app/result/components/status/status.py 45.23% 23 Missing ⚠️
...pp/result/components/viewer/structure/structure.py 53.84% 6 Missing ⚠️
src/aiidalab_qe/common/panel.py 81.81% 6 Missing ⚠️
...aiidalab_qe/app/result/components/viewer/viewer.py 93.93% 4 Missing ⚠️
src/aiidalab_qe/app/submission/model.py 62.50% 3 Missing ⚠️
src/aiidalab_qe/app/result/components/__init__.py 93.33% 2 Missing ⚠️
..._qe/app/result/components/summary/download_data.py 0.00% 2 Missing ⚠️
...idalab_qe/app/result/components/summary/summary.py 92.85% 2 Missing ⚠️
src/aiidalab_qe/plugins/xps/result/result.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   68.42%   69.05%   +0.63%     
==========================================
  Files         111      115       +4     
  Lines        6292     6388      +96     
==========================================
+ Hits         4305     4411     +106     
+ Misses       1987     1977      -10     
Flag Coverage Δ
python-3.11 69.05% <84.44%> (+0.63%) ⬆️
python-3.9 69.07% <84.44%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edan-bainglass , thanks for the nice work!

@edan-bainglass edan-bainglass merged commit aad3410 into aiidalab:main Dec 19, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants