Skip to content

Commit

Permalink
Fix Warning coming from ProcessFollowerWidget (#512)
Browse files Browse the repository at this point in the history
We were passing a wrong thing to the ProcessMonitor constructor,
but because it was just ignored as an extra keyword argument,
it did not manifest as an actual bug.
The functionality itself worked because we were passing
the process uuid by linking the traitlets via `dlink()`.

* Longer default timeout in ProcessFollowerWidget
---------

Co-authored-by: Jusong Yu <jusong.yeu@gmail.com>
  • Loading branch information
danielhollas and unkcpz authored Sep 8, 2023
1 parent 5309f5d commit 7afc300
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions aiidalab_widgets_base/process.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def __init__(
self,
process=None,
followers=None,
update_interval=0.1,
update_interval=1.0,
path_to_root="../",
**kwargs,
):
Expand Down Expand Up @@ -302,7 +302,6 @@ def follow(self, detach=False):

if self._monitor is None:
self._monitor = ProcessMonitor(
process=self.process,
callbacks=[self.update],
on_sealed=self._run_after_completed,
timeout=self.update_interval,
Expand Down

0 comments on commit 7afc300

Please sign in to comment.