Extend documentation for the viewers module. #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
=======================================
Coverage 82.79% 82.79%
=======================================
Files 27 27
Lines 4313 4313
=======================================
Hits 3571 3571
Misses 742 742
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
unkcpz
reviewed
Nov 3, 2023
unkcpz
requested changes
Nov 3, 2023
There was a problem hiding this comment.
Hi @yakutovicha, only one minor request. I think we can get this merged and keep working on the others.
One thing to discuss, do we want to have a gif for the widget? The ultimate solution could be fancy technology like jupyter book, but a gif allowed us to provide more control on what we want to show to the users.
…/aiidalab/aiidalab-widgets-base into docs/extend-viwers-documentation
unkcpz
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.