Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add auxiliary cell to uploaded/generated structures #592

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielhollas
Copy link
Contributor

@danielhollas danielhollas commented Apr 29, 2024

If such functionality is needed, it must be optional.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (7c9a3ef) to head (f70accc).
Report is 5 commits behind head on master.

Current head f70accc differs from pull request most recent head bf63f0d

Please upload reports for the commit bf63f0d to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          11       11           
  Lines        1188     1188           
=======================================
  Hits         1143     1143           
  Misses         45       45           
Flag Coverage Δ
python-3.10 96.21% <ø> (ø)
python-3.9 96.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas danielhollas added this to the v0.2.3 milestone May 28, 2024
@danielhollas danielhollas force-pushed the remove-auxiliary-cell branch from f70accc to bf63f0d Compare June 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant