Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard module file from static styles folder #632

Closed
wants to merge 2 commits into from

Conversation

edan-bainglass
Copy link
Member

Replaced module loading with using direct path in #624

Replaced module loading with using direct path in aiidalab#624
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.49%. Comparing base (ce9cfe9) to head (b925206).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #632   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files          17       17           
  Lines        3539     3539           
=======================================
  Hits         2955     2955           
  Misses        584      584           
Flag Coverage Δ
python-3.11 83.49% <0.00%> (ø)
python-3.9 83.53% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edan-bainglass
Copy link
Member Author

Interesting. So the __init__.py file is required in static/styles even though it is no longer used as a module. This is because without it, the styles directory does not transfer to site-packages on install, and hence is not found by the loader. Thanks @superstar54 for assisting in debugging this.

@edan-bainglass edan-bainglass deleted the static branch September 19, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant