Replace check of empty string in unfilled template widgets to None
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edan-bainglass
force-pushed
the
FIX/#647
branch
from
bb6fe75 to
6b38f0e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #650 +/- ##
==========================================
- Coverage 83.47% 83.46% -0.01%
==========================================
Files 17 17
Lines 3558 3556 -2
==========================================
- Hits 2970 2968 -2
Misses 588 588
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edan-bainglass
force-pushed
the
FIX/#647
branch
from
6b38f0e to
6544d18
Compare
|
Also thanks for following up on this @edan-bainglass! 🤟 |
100% why I tagged @unkcpz 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects a guard for unfilled template variables which checks if the value of the corresponding widget is an empty string. Empty widgets may also be represented by
None, especially dropdown selectors. This PR addsNoneto the check by comparing the widget's value to both - replaces== ""within ("", None).Resolves #648
Resolves #651
@superstar54 @danielhollas have a look 🙏
@unkcpz tagging you due to git blame (suggests you implemented these sections)