-
Notifications
You must be signed in to change notification settings - Fork 235
uv.lock upgrade #7077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uv.lock upgrade #7077
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7077 +/- ##
==========================================
- Coverage 79.62% 79.61% -0.01%
==========================================
Files 566 566
Lines 43546 43546
==========================================
- Hits 34669 34664 -5
- Misses 8877 8882 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Marking as draft until I can investigate the test failures (memory_leak tests are failing, but only for some Python versions?) |
2d2b57b to
ccc9f40
Compare
| # .github/actions/install-aiida-core/action.yml | ||
| # .readthedocs.yml | ||
| required-version = ">=0.7.0" | ||
| required-version = ">=0.8.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different from 0.9.7 used in the other places? Why this minimum required version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the following comment, let me know if it makes things clearer:
# We specify a minimum uv version so that the format of uv.lock file
# does not change depending on uv version that a particular developer has installed.
# The uv.lock format is versioned, using the "version" and "revision" fields in uv.lock,
# and the minimum version here should be the first one that introduced a given version/revision.
|
Thanks, @danielhollas! Pls resolve conflicts then I approve 🙏🏽 |
ccc9f40 to
b1141ef
Compare
6d177fc to
b1141ef
Compare
|
I am fixing the test-install job in #7103 which should be merged first |
b1141ef to
e68161b
Compare
Yeah, I wasn't very precise here. Basicaly when I tried to use Python 3.14 with |
|
@GeigerJ2 is this one good to merge? |
Pull the trigger! 🔫 |
Lock upgrade is a pre-requisite for supporting Python 3.14. Split from #7074
Output of `uv lock --upgrade`
EDIT: I also tried to upgrade pytest to 8.x but ran into issues with leak tests so will do that in a separate PR.