🐛 OpenSSH backend: ignore benign path check warnings#7313
Open
officialasishkumar wants to merge 1 commit intoaiidateam:mainfrom
Open
🐛 OpenSSH backend: ignore benign path check warnings#7313officialasishkumar wants to merge 1 commit intoaiidateam:mainfrom
officialasishkumar wants to merge 1 commit intoaiidateam:mainfrom
Conversation
Treat the expected exit codes from the remote test command as the authoritative exists/not-exists result, even when OpenSSH writes harmless warnings to stderr. Unexpected exit codes still raise with the stderr context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7311
_OpenSSH.path_existsnow treats thetest -ereturn code as the source of truth:0means the path exists,1means it does not. Any stderr from those expected outcomes is logged for debugging instead of being raised, which avoids failing on harmless OpenSSH host-key warnings. Unexpected return codes still raise with the stderr context.Validation:
pytest tests/transports/test_asyncssh_plugin.py -k path_existspython3 -m compileall -q src/aiida/transports/plugins/async_backend.py tests/transports/test_asyncssh_plugin.pyruff check --ignore PLC0415,RUF059 src/aiida/transports/plugins/async_backend.py tests/transports/test_asyncssh_plugin.py