👌 Scheduler.get_jobs: fix as_dict overload#7314
Open
officialasishkumar wants to merge 1 commit intoaiidateam:mainfrom
Open
👌 Scheduler.get_jobs: fix as_dict overload#7314officialasishkumar wants to merge 1 commit intoaiidateam:mainfrom
Scheduler.get_jobs: fix as_dict overload#7314officialasishkumar wants to merge 1 commit intoaiidateam:mainfrom
Conversation
Remove the duplicate default from the Literal[True] overload while keeping jobs and user positional-compatible with the runtime implementation.
officialasishkumar
changed the title
Scheduler.get_jobs: fix as_dict overload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7296
The overload returning a dictionary no longer declares
as_dict: Literal[True] = True. Instead,as_dictis required as a keyword-only literal whilejobsanduserremain positional-compatible with the runtime implementation.Validation:
python3 -m compileall -q src/aiida/schedulers/scheduler.py src/aiida/schedulers/plugins/bash.py src/aiida/schedulers/plugins/direct.pyruff check --ignore PLC0415 src/aiida/schedulers/scheduler.py src/aiida/schedulers/plugins/bash.py src/aiida/schedulers/plugins/direct.pymypy --config-file=pyproject.toml --follow-imports=skip --disable-error-code=misc --disable-error-code=untyped-decorator src/aiida/schedulers/scheduler.py src/aiida/schedulers/plugins/bash.py src/aiida/schedulers/plugins/direct.py