✨ Add --clean-workdir to verdi group delete#7315
Open
officialasishkumar wants to merge 1 commit intoaiidateam:mainfrom
Open
✨ Add --clean-workdir to verdi group delete#7315officialasishkumar wants to merge 1 commit intoaiidateam:mainfrom
officialasishkumar wants to merge 1 commit intoaiidateam:mainfrom
Conversation
Support cleaning remote CalcJobNode work directories when deleting group nodes, reusing the existing node deletion cleanup flow and adding CLI coverage for the new option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7299
This adds
--clean-workdirtoverdi group deletewhen used together with--delete-nodes. The implementation reuses the existing node deletion cleanup flow so the same dry-run, confirmation, already-cleaned, and stash-warning behavior is shared.Validation:
pytest tests/cmdline/commands/test_group.py -k "delete_clean_workdir or test_delete"pytest tests/cmdline/commands/test_node.py -k node_deletewith the local venv bin directory onPATHfor subprocess-based casespython3 -m compileall -q src/aiida/cmdline/commands/cmd_node.py src/aiida/cmdline/commands/cmd_group.py tests/cmdline/commands/test_group.pyruff check --ignore PLC0415 src/aiida/cmdline/commands/cmd_node.py src/aiida/cmdline/commands/cmd_group.py tests/cmdline/commands/test_group.py