Fix max_iterations not overridden and add tests for PhBaseWorkChain protocols
#984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `PhBaseWorkChain.get_builder_from_protocol` was untested. Tests are added, and the `electronic_type` input is added to allow for the computation of the dielectric and effective charge tensors when an insulator is in input. This is useful in other workchains, so that the `electronic_type` input can be passed seamlessly as a kwargs input at an higher level.
Fixes #966 All the base workchains missed to override the `max_iterations` input. This is now fixed for all of them.
sphuber
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the base workchains were missing to override the
max_iterationsinput.The
PhBaseWorkChain.get_builder_from_protocolwas still untested. Tests are added and theelectronic_typeinput is added as well to allow for the automated/user-friendly computation of dielectric and effective charges tensors when needed (i.e. for insulators).