Update build to fix CI #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some sphinx internal warnings that are time consuming to debug and don't affect the quality of the tutorial page, so we ignore them by treating warnings as warnings.
The current pinned version in the requirements do not work anymore so all pinning of versions have been removed.
agoscinski
changed the title
agoscinski
force-pushed
the
fix/build
branch
5 times, most recently
from
c51943e to
a14060e
Compare
- pipx has been updated - virtual box does not work for the moment so we have to ignore it. - the underscore explanation link works but somehow is marked as broken so we replace with an explanation from realpython - big-map.eu does not work but is sponsor so cannot be replaced/removed
Update to python 3.11 and update sphinx and subsequent dependencies.
RTD wants that the version is now specified in the build.tools. Updated to python 3.12
Uses latest version, also the python version should not matter for a formatter.
agoscinski
force-pushed
the
fix/build
branch
from
a14060e to
5387dc4
Compare
GeigerJ2
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Shouldn't we pin the versions here?
There was a problem hiding this comment.
We can pin them. Sometimes it is more annoying than helpful to pin verison if a repo changes frequently and needs to update its dependencies. But I guess in this case we only need to update the occasionally.
There was a problem hiding this comment.
Yeah, I usually had the same experience so far, and ended up not pinning them usually :D
agoscinski
commented
Sep 11, 2024
There was a problem hiding this comment.
We can pin them. Sometimes it is more annoying than helpful to pin verison if a repo changes frequently and needs to update its dependencies. But I guess in this case we only need to update the occasionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just updating all the files and dependencies.
Maybe controversial change is that I removed the
-Wflag during the sphinx-build process, so warnings are treated as warnings and not as errors. The reason for this is because I got sphinx warnings which in my experience are very hard to debug and only marginal add to the quality to the doc page. I will not fix these warnings.