Drop WG.submit/run for core engine.submit/run#768
Draft
GeigerJ2 wants to merge 11 commits intoaiidateam:mainfrom
Draft
Drop WG.submit/run for core engine.submit/run#768GeigerJ2 wants to merge 11 commits intoaiidateam:mainfrom
GeigerJ2 wants to merge 11 commits intoaiidateam:mainfrom
Conversation
GeigerJ2
force-pushed
the
refactor/move-run_submit-to-core
branch
from
a0db89e to
0e460a7
Compare
`prepare_for_launch` now pops `metadata`, `timeout`, and `interval` from the merged inputs dict before passing to `set_inputs`, preventing `KeyError`s when these execution parameters are passed via aiida-core `submit()`. Tests that relied on `submit(wg, wait=True, timeout=...)` now use the `submit(wg)` + `wg.wait(timeout=...)` pattern instead, since timeout is a client-side poll parameter handled by `WorkGraph.wait()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has to go together with: aiidateam/aiida-core#7261
All tests passing. Only RTD build failing, as I did not manage to point the
aiida-coreversion used for the build to my PR branch.