-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHF benchmark using synthetic data, paper finalized fixes too #63
Conversation
…s, MAPE/RMSPE, scatter error plot
Thanks Patrick for the work. I did go through my list and yours and they cross in many points. I will repeat those points below since they are not explicitly mentioned in your report, but sorry if they were already embedded: 1- Aside from that, I look forward to pip install the new version. |
Also forgot to add for the printing of NN structure, you may add the number of nodes for the input and output layers and test the printer with LSTM and CNN to see if it consistent. |
PR Description
This PR includes the CHF benchmark, described in the benchmark at
docs/source/benchmarks/chf.ipynb
and in the docstring ofpyMAISE.datasets.load_chf()
. This PR also includes some quality-of-life fixes before paper publication. These are listed below.Closes: #49
Closes: #51
What changes were made?
pyMAISE.datasets.load_chf()
tensorflow.keras.Input
layer for building DNNs inpyMAISE.methods.nnHyperModel.build()
pyMAISE.utils.display._try_clear()
, and used this function throughout pyMAISE routinepyMAISE.PostProcessor
andpyMAISE.CVTuner
pyMAISE.PostProcessor.confusion_matrix()
and included both number and percentage, handles binary and multiclass casespyMAISE.PostProcessor.metrics()
and added mean absolute percentage error (MAPE) and root mean squared percentage error (RMSPE)pyMAISE.PostProcessor.validation_plot()
to scatter plotpyMAISE.PostProcessor.print_model()
) for readable NN hyperparameterspyMAISE.PostProcessor.nn_network_plot()
Reviewers: @mradaideh