Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing upstream unit tests for httpchecksum #1294

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Add missing upstream unit tests for httpchecksum

Assumptions

Patched codepaths should be covered by unit tests.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 97.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.84%. Comparing base (7c41f8a) to head (8d716f1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
tests/boto_tests/unit/test_httpchecksum.py 97.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1294      +/-   ##
==========================================
+ Coverage   88.69%   89.84%   +1.14%     
==========================================
  Files          67       67              
  Lines        5875     6083     +208     
==========================================
+ Hits         5211     5465     +254     
+ Misses        664      618      -46     
Flag Coverage Δ
unittests 89.84% <97.14%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller marked this pull request as ready for review February 14, 2025 22:21
…`.handle_checksum_body`, and `.StreamingChecksumBody`
@jakob-keller jakob-keller added this pull request to the merge queue Feb 19, 2025
Merged via the queue into aio-libs:master with commit 3eabc88 Feb 19, 2025
18 checks passed
@jakob-keller jakob-keller deleted the httpchecksum-tests branch February 19, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants