Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt upstream unit tests session.TestCreateClient #1309

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Feb 28, 2025

Description of Change

  • Adopt upstream unit tests for session:
    • TestSessionPartitionFiles
    • TestGetServiceModel
    • TestCreateClient
    • TestClientMonitoring

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Feb 28, 2025
@jakob-keller jakob-keller force-pushed the upstream-session-tests branch from 623aa11 to ab5b3e5 Compare February 28, 2025 00:17
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (7009ebe) to head (b49b6a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1309      +/-   ##
==========================================
+ Coverage   89.81%   90.38%   +0.57%     
==========================================
  Files          67       68       +1     
  Lines        6055     6336     +281     
==========================================
+ Hits         5438     5727     +289     
+ Misses        617      609       -8     
Flag Coverage Δ
unittests 90.38% <100.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller force-pushed the upstream-session-tests branch from ab5b3e5 to 72d00b5 Compare February 28, 2025 00:31
@jakob-keller jakob-keller marked this pull request as ready for review February 28, 2025 00:37
@jakob-keller jakob-keller force-pushed the upstream-session-tests branch from 72d00b5 to 8283bf1 Compare February 28, 2025 00:56
@jakob-keller jakob-keller marked this pull request as draft February 28, 2025 00:58
auto-merge was automatically disabled February 28, 2025 00:58

Pull request was converted to draft

@jakob-keller jakob-keller removed the request for review from thehesiod February 28, 2025 00:58
@jakob-keller jakob-keller force-pushed the upstream-session-tests branch from 8283bf1 to 4633781 Compare February 28, 2025 01:07
…GetServiceModel`, `.TestCreateClient`, and `.TestClientMonitoring`
@jakob-keller jakob-keller force-pushed the upstream-session-tests branch from 4633781 to b49b6a9 Compare February 28, 2025 01:12
@jakob-keller jakob-keller marked this pull request as ready for review February 28, 2025 01:16
@jakob-keller jakob-keller added this pull request to the merge queue Feb 28, 2025
Merged via the queue into aio-libs:master with commit 295cc41 Feb 28, 2025
18 checks passed
@jakob-keller jakob-keller deleted the upstream-session-tests branch February 28, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants