Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize botocore tests #1311

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Feb 28, 2025

Description of Change

  • remove commented out code
  • rename boto_tests to botocore_tests

Assumptions

tests/botocore_tests should be closely aligned with upstream

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller changed the title Reorganize boto tests Reorganize botocore tests Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (1a35466) to head (b2ae635).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1311      +/-   ##
==========================================
- Coverage   90.76%   90.72%   -0.05%     
==========================================
  Files          68       68              
  Lines        6542     6542              
==========================================
- Hits         5938     5935       -3     
- Misses        604      607       +3     
Flag Coverage Δ
unittests 90.72% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thehesiod
thehesiod previously approved these changes Feb 28, 2025
@jakob-keller jakob-keller added this pull request to the merge queue Feb 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 28, 2025
@jakob-keller
Copy link
Collaborator Author

@thehesiod: Sorry, I had to rebase the PR due to conflicts. Should be a quick review. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants