Skip to content

Conversation

@Cycloctane
Copy link
Member

@Cycloctane Cycloctane commented Oct 29, 2025

What do these changes do?

Forks do not have token for codspeed, which can make benchmark job in ci fail if aiohttp contributors want to run test workflow on their forks. This pr make unnecessary steps skip if triggered workflow is not in the main repository.

Are there changes in behavior for the user?

aiohttp contributors can now run github action workflows to test changes in their forks without unnecessary errors.

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder

@Cycloctane Cycloctane requested a review from webknjaz as a code owner October 29, 2025 06:23
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 29, 2025

CodSpeed Performance Report

Merging #11737 will not alter performance

Comparing Cycloctane:skip-workflows-in-forks (4da6f39) with master (056d929)

Summary

✅ 59 untouched

@Cycloctane Cycloctane requested a review from asvetlov as a code owner October 29, 2025 06:49
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 29, 2025
@Cycloctane Cycloctane changed the title Skip codecov uploads and benchmarks in ci when running in forks Skip codecov uploads and benchmarks in ci when running in fork repositories Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (e260b15) to head (ce2b9b3).
⚠️ Report is 112 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11737      +/-   ##
==========================================
- Coverage   98.74%   98.74%   -0.01%     
==========================================
  Files         127      127              
  Lines       43448    43754     +306     
  Branches     2326     2328       +2     
==========================================
+ Hits        42903    43205     +302     
  Misses        389      389              
- Partials      156      160       +4     
Flag Coverage Δ
CI-GHA 98.61% <ø> (-0.02%) ⬇️
OS-Linux 98.35% <ø> (-0.02%) ⬇️
OS-Windows 96.68% <ø> (-0.02%) ⬇️
OS-macOS 97.57% <ø> (-0.01%) ⬇️
Py-3.10.11 97.12% <ø> (-0.03%) ⬇️
Py-3.10.18 97.61% <ø> (-0.04%) ⬇️
Py-3.11.13 97.81% <ø> (-0.03%) ⬇️
Py-3.11.9 97.32% <ø> (-0.03%) ⬇️
Py-3.12.10 97.43% <ø> (-0.03%) ⬇️
Py-3.12.11 97.92% <ø> (-0.03%) ⬇️
Py-3.13.7 97.92% <ø> (-0.29%) ⬇️
Py-3.13.9 97.41% <ø> (?)
Py-3.14.0 98.12% <ø> (-0.04%) ⬇️
Py-3.14.0t 97.19% <ø> (-0.03%) ⬇️
Py-pypy3.10.16-7.3.19 92.95% <ø> (-3.43%) ⬇️
VM-macos 97.57% <ø> (-0.01%) ⬇️
VM-ubuntu 98.35% <ø> (-0.02%) ⬇️
VM-windows 96.68% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webknjaz
Copy link
Member

The preferred solution is storing the plain text token fore Codecov. As for codspeed, I haven't seen it failing. Do you have any examples?

FWIW, the repo checks should be done through repo IDs.

@Cycloctane Cycloctane changed the title Skip codecov uploads and benchmarks in ci when running in fork repositories Skip benchmarks in ci when running in fork repositories Oct 29, 2025
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, though, if benchmarking could still run but just skip uploading the results, conditionally. Could you check?

Cycloctane and others added 3 commits October 30, 2025 21:57
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@webknjaz
Copy link
Member

webknjaz commented Nov 5, 2025

I wonder, though, if benchmarking could still run but just skip uploading the results, conditionally. Could you check?

@Cycloctane have you been able to check if this is possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants