-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Skip benchmarks in ci when running in fork repositories #11737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #11737 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11737 +/- ##
==========================================
- Coverage 98.74% 98.74% -0.01%
==========================================
Files 127 127
Lines 43448 43754 +306
Branches 2326 2328 +2
==========================================
+ Hits 42903 43205 +302
Misses 389 389
- Partials 156 160 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The preferred solution is storing the plain text token fore Codecov. As for codspeed, I haven't seen it failing. Do you have any examples? FWIW, the repo checks should be done through repo IDs. |
webknjaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder, though, if benchmarking could still run but just skip uploading the results, conditionally. Could you check?
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@Cycloctane have you been able to check if this is possible? |
What do these changes do?
Forks do not have token for codspeed, which can make benchmark job in ci fail if aiohttp contributors want to run test workflow on their forks. This pr make unnecessary steps skip if triggered workflow is not in the main repository.
Are there changes in behavior for the user?
aiohttp contributors can now run github action workflows to test changes in their forks without unnecessary errors.
Is it a substantial burden for the maintainers to support this?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES/folder