Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement graceful shutdown on Mac #618

Closed
wants to merge 8 commits into from
Closed

Implement graceful shutdown on Mac #618

wants to merge 8 commits into from

Commits on Apr 30, 2024

  1. hold cleanup until procKilledCh signal

    @sethbrasile
    sethbrasile committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4d7d7a8 View commit details
    Browse the repository at this point in the history

  2. signal to procKilledChan in existing deferred func

    @sethbrasile
    sethbrasile committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0dcd9c5 View commit details
    Browse the repository at this point in the history

  3. without this can't exit when non zero exit code 

    it seems like `os.Exit(state.ExitCode())` belongs here... but unclear on intent of `e.config.Build.Rerun`

This at least lets you ctrl+c out of error condition instead of killing pid via external means.
    @sethbrasile
    sethbrasile committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fec348c View commit details
    Browse the repository at this point in the history

  4. Revert "without this can't exit when non zero exit code" 

    This reverts commit fec348c.
    @sethbrasile
    sethbrasile committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7034632 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Merge branch 'cosmtrek:master' into master

    @sethbrasile
    sethbrasile authored May 15, 2024
    Configuration menu
    Copy the full SHA
    8e99edc View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. use cleanup

    @xiantang
    xiantang committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    674a5b9 View commit details
    Browse the repository at this point in the history

  2. fix test case rerun

    @xiantang
    xiantang committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    a759095 View commit details
    Browse the repository at this point in the history

  3. upgrade gomod version

    @xiantang
    xiantang committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    609de5a View commit details
    Browse the repository at this point in the history