-
-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement graceful shutdown on Mac #619
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
aa4a5ac
hold cleanup until procKilledCh signal
sethbrasile d1a45b8
signal to procKilledChan in existing deferred func
sethbrasile 240f4c1
without this can't exit when non zero exit code
sethbrasile 1f78251
Revert "without this can't exit when non zero exit code"
sethbrasile d312f15
use cleanup
xiantang cf8e797
fix test case rerun
xiantang 360714a
upgrade gomod version
xiantang 849e029
remove unused `WaitGroup`
xiantang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I don't understand is why the WaitGroup passed to
killFunc
on line 553 doesn't seem to be working properly, I'd expect that to have waited for the process to be killed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No that's expected of course, but the WaitGroup that function expects as an argument is defined on 522 and is only ever
Wait
ed on line 528, so perhaps waiting on that wasn't working as expected or theWait
wasn't being called every time. To me, at least, figuring that out seems like a better solution than adding yet another WaitGroupThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when i remove the wg.Done(), the we still can exit. i think it's pointer issue. because we put the pointer into funtion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh i see https://github.com/cosmtrek/air/blob/360714a021b1b77e50a5656fefc4f8bb9312d328/runner/engine.go#L520-L522, bcs it's running inside the new goroutine, and We didn't use something like
join
to let main goroutine to wait son goroutine, so main goroutine don't even FXXK care about that sub goroutine.i think we should remove this useless
WaitGroup