Use web page address when making request to reload proxy #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandra Fishova <yopoyka@yopoyka.com>
…ss on its own. Signed-off-by: Alexandra Fishova <yopoyka@yopoyka.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
jesses-code-adventures
pushed a commit
to jesses-code-adventures/air
that referenced
this pull request
Sep 25, 2024
* Use web page address when making request to reload proxy Signed-off-by: Alexandra Fishova <yopoyka@yopoyka.com> * Create event source with just a path because browser can handle address on its own. Signed-off-by: Alexandra Fishova <yopoyka@yopoyka.com> --------- Signed-off-by: Alexandra Fishova <yopoyka@yopoyka.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I often use tailscale to share development process of web pages with my team. Using tailscale you can create a tunnel from your local machine with a public address such as
machine.id.ts.netbut air always connects tolocalhostso live reload can't work on my teammates browsers.This pr makes browser reload script connect to web page's host.
It works with
localhost:portand with regular addresses. It works with bothhttpandhttps.I've ran it on linux firefox, chrome and on macOS safari. Seems to be working all right.