Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor startCmd() related code #653

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Refactor startCmd() related code #653

wants to merge 8 commits into from

Conversation

8LWXpg
Copy link
Contributor

@8LWXpg 8LWXpg commented Sep 22, 2024

This PR does the following:

  • Removed the return of Stdout, Stderr in startCmd().
  • Removed code related to returned stderr and stdout.
  • The command now maps Stdin, allowing it to support input from stdin..
  • Removed the check for the .exe file extension on Windows, since executing .exe files without the extension is supported.

@codecov Codecov
Copy link

codecov bot commented Sep 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
runner/util_unix.go 80.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
runner/config.go 79.36% <ø> (+0.83%) ⬆️
runner/engine.go 62.56% <100.00%> (-1.76%) ⬇️
runner/util_unix.go 80.00% <80.00%> (+12.00%) ⬆️

... and 2 files with indirect coverage changes

@8LWXpg 8LWXpg marked this pull request as draft September 22, 2024 08:29
@8LWXpg 8LWXpg marked this pull request as ready for review September 23, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@8LWXpg