Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svgo dependency to latest version #64

Closed
wants to merge 1 commit into from
Closed

Update svgo dependency to latest version #64

wants to merge 1 commit into from

Conversation

haideralsh
Copy link

This is to resolve the Code Injection vulnerability with the js-yaml package that svgo depends on.

This is to resolve the Code Injection vulnerability with the js-yaml package that svgo depends on.
@haideralsh haideralsh closed this Jun 6, 2019
@ljharb
Copy link
Collaborator

ljharb commented Jun 6, 2019

Duplicate of #34, #35.

Also, this is not a vulnerability - it's just a false positive.

@haideralsh
Copy link
Author

I understand it's a false positive, but as others have mentioned it creates noise in the npm audit output, especially that the vulnerability is "high".

What is the reason behind not wanting to update the dependency?

@ljharb
Copy link
Collaborator

ljharb commented Jun 7, 2019

It’s not about wanting; we can’t - the upgraded version is only asynchronous, and Babel transforms must be synchronous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants