Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix radial gradient crash #2611

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Fix radial gradient crash #2611

merged 2 commits into from
Mar 3, 2025

Conversation

dazza5000
Copy link
Contributor

Fixes #2610

gpeal
gpeal reviewed Mar 2, 2025
View reviewed changes
Copy link
Collaborator

@gpeal gpeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a failing json file here. It will automatically get added to the snapshot regression tests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2025

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@dazza5000
Copy link
Contributor Author

thank you @gpeal - I added a test case - I couldn't discern the correct file naming format so you I used Snake Case

@dazza5000 dazza5000 requested a review from gpeal March 3, 2025 15:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@gpeal gpeal merged commit ac2599c into airbnb:master Mar 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpeal gpeal gpeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RadialGradient Crash - java.lang.IllegalArgumentException: needs >= 2 number of colors
2 participants
@dazza5000 @gpeal