fix: Configure shadow jar as main artifact for fat jar modules#274
Open
fireboy1919 wants to merge 1 commit intoairbnb:mainfrom
Open
fix: Configure shadow jar as main artifact for fat jar modules#274fireboy1919 wants to merge 1 commit intoairbnb:mainfrom
fireboy1919 wants to merge 1 commit intoairbnb:mainfrom
Conversation
The shadow plugin was building fat jars correctly, but Gradle's apiElements and runtimeElements variants were still pointing to the thin jar. This caused standalone consumers to get an empty jar instead of the fat jar with bundled classes. Fix by configuring apiElements and runtimeElements to use the shadow jar artifact directly. The isCompositeBuild logic is preserved to keep internal dependencies as implementation scope in published POMs.
fireboy1919
force-pushed
the
fix-shadow-jar-publishing
branch
from
b59f86d to
24cd66d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
- Fix shadow jar publishing so standalone consumers get the fat jar instead of the empty thin jar
- Configure
- Remove the
fix: Configure shadow jar as main artifact for fat jar modulesapiElementsandruntimeElementsvariants to use the shadow jar artifactisCompositeBuildconditional logic (no longer needed with proper fat jar publishing)The shadow plugin was building fat jars correctly, but Gradle's apiElements and
runtimeElements variants were still pointing to the thin jar. This caused standalone
consumers to get an empty jar instead of the fat jar with bundled classes.
Test Plan
./gradlew :cli-starter:test :jetty-starter:test