Create better status bar API + Structure, add time to status bar #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time That situation is possible since 59a1b3d
| bar.addItem(clock); | ||
|
|
||
| // Update clock on time changes (500 to account for errant synchronization) | ||
| setInterval(updateTime,500); |
There was a problem hiding this comment.
Could you line this up entirely by doing a setTimeout with 1000 - currentTime.getMilliseconds() after you update the time?
|
Cool! Could you horizontally center the clock and have the cursor be default? Also, was it intentional to make the power button larger? |
|
If we are using the status bar for minimized (or maximized #6) windows, does it make sense to center the clock? I have addressed all your other comments! |
|
Er, I meant vertically center. Sorry. |
|
Done! |
|
👍. Two more things: the |
twiss
force-pushed
the
master
branch
2 times, most recently
from
0b9352f
to
cec9cb4
Compare
|
Merged as cec9cb4. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.