Skip to content

ci: add check for 'do not merge' in PR titles #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Add check for 'do not merge' in PR titles

This PR adds a check to prevent PRs with 'do not merge' or 'do-not-merge' in the title from merging. The check is case-insensitive and runs after the semantic PR title check.

The check will fail if a PR title contains either "do not merge" or "do-not-merge" anywhere in the title, regardless of casing or surrounding characters.

Link to Devin run: https://app.devin.ai/sessions/bde79d1047584bf09327a9c5f38873c8

Requested by: Aaron (@aaronsteers)

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

Received message in Slack channel #dev-devin-ai:

@Devin - I noticed some CDK PRs are merging with "(do not merge)" in the title. I'd like to prevent this in one of these two methods:
1. Add logic into the semantic PR title CI check, if it is supported to do so.
2. Otherwise, do our own check immediately after to that step running - raising an error there if "do not merge" exists in the PR title (in any casing).
Don't change the conditions of the CI job running, only adding this new failure condition when it is running.

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the ci label Mar 4, 2025
@aaronsteers
Copy link
Contributor

Merging with failed test. The only failed test is the one that proves the behavior we wanted. 🚀

https://github.com/airbytehq/airbyte-python-cdk/actions/runs/13662746310/job/38197414923?pr=383

image

@aaronsteers aaronsteers merged commit fdfeef7 into main Mar 4, 2025
18 of 19 checks passed
@aaronsteers aaronsteers deleted the devin/1741121601-prevent-do-not-merge branch March 4, 2025 20:57
rpopov added a commit to rpopov/airbyte-python-cdk that referenced this pull request Mar 5, 2025
* main:
  ci: add Docker build workflow for PR checks (airbytehq#385)
  fix: Update DEFAULT_ERROR_MAPPING for InvalidURL to RETRY (airbytehq#384)
  chore: use python base image 4.0.0 in SDM (airbytehq#382)
  ci: add check for 'do not merge' in PR titles (airbytehq#383)
  chore: remove embedded module (airbytehq#380)
  build: update pyarrow to ^19.0.0 (do not merge) (airbytehq#379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant