Add Label 22 Takeoff Report #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
makrsmark
commented
Oct 29, 2024
makrsmark
commented
- renamed Label_22 to Label_22_POS and added preambles
- renamed Label_22 to Label_22_POS and added preambles
makrsmark
commented
Oct 29, 2024
Comment on lines
+41
to
+42
| expect(decodeResult.formatted.items[3].label).toBe('Message Timestamp'); | ||
| expect(decodeResult.formatted.items[3].value).toBe('17:12:00'); |
There was a problem hiding this comment.
this is a little weird, but what I'm calling the timestamp has minute resolution, but the actual takeoff time has second resolution. Open to ideas
There was a problem hiding this comment.
I would say that as long as the raw value is still defined with seconds, the formatted can be whatever.
Comment on lines
+71
to
+72
| expect(decodeResult.formatted.items[3].label).toBe('Message Timestamp'); | ||
| expect(decodeResult.formatted.items[3].value).toBe('11:52:00'); |
There was a problem hiding this comment.
in this variant, both the timestamp and takeoff time have minute resolution - i could be parsing backwards but it probably doesn't matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.