Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple security schemes in OpenAPI Client #235

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

kumaranvpl
Copy link
Collaborator

@kumaranvpl kumaranvpl commented Sep 17, 2024

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes #145

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fastagency/api/openapi/client.py 78.57% 1 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
fastagency/api/openapi/client.py 86.84% <78.57%> (+2.58%) ⬆️

... and 1 file with indirect coverage changes

fastagency/api/openapi/client.py Outdated Show resolved Hide resolved
@kumaranvpl kumaranvpl dismissed davorrunje’s stale review September 17, 2024 08:00

Changes done but PR still is being blocked. So dismissing the review.

@rjambrecic rjambrecic added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 55498ce Sep 17, 2024
22 checks passed
@rjambrecic rjambrecic deleted the multiple-security branch September 17, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multiple security schema
3 participants