fix: correct dependency injection of custom context fields implementing partial __eq__/__ne__ #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…custom field value implements __eq__/__ne__ returning NotImplemented
Lancetnik
previously approved these changes
Sep 24, 2024
|
LGTM, thank you! |
|
Sorry for not executing the pre-commit check before submitting PR. Do you want me to correct those errors ? |
Lancetnik
requested changes
Sep 24, 2024
antoinehumbert
force-pushed
the
bugfix/custom_context_eq
branch
from
afa1126
to
998b236
Compare
Lancetnik
previously approved these changes
Sep 24, 2024
|
@antoinehumbert can you run precommit please? 😄 |
|
Will do tomorrow. Sorry for the inconvinience. |
Np! I am planning to make a release tomorrow. It will be great to see your fix in it |
antoinehumbert
force-pushed
the
bugfix/custom_context_eq
branch
from
998b236
to
44ef30b
Compare
|
Hi! Everything looks good now. |
Lancetnik
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1806
It includes 2 regression tests related to both corrections in
faststream.utils.context.typesfor the 2 use cases where value is compared to EMPTY.Note that the issue description is incorrect as the custom field class must implement
__ne__and not only__eq__to trigger the problem. This is the reason for theUserimplementation provided in regression test.Please, let me know if PR needs some improvements.