Allow _resolvePlural to search _fallbackTranslation values when trying to resolve a plural key #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anslations is null or not
bw-flagship
requested changes
Sep 5, 2023
- update test case for plural with fallback priority
bw-flagship
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure of the logic/reasoning behind line 181, where the call to
_resolveis forcingfallbackparam to always be false.That means if you are using fallback translations (
_fallbackTranslationsis not null and has values)_resolvePluralshould respect that and attempt to resolve any plural keys that exist in the fallback translations map.