Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _supportedLocales in EasyLocalizationController; check the device… #672

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

bbsmartc
Copy link
Contributor

@bbsmartc bbsmartc commented May 1, 2024

add _supportedLocales in EasyLocalizationController; check the deviceLocale in resetLocale;

to fix this issue

add scriptCode if useOnlyLangCode

scriptCode is needed sometimes, for example zh-Hans, zh-Hant

…Locale in resetLocale; add scriptCode if useOnlyLangCode
Copy link
Collaborator

@bw-flagship bw-flagship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh and please add this to the changelog

@bbsmartc
Copy link
Contributor Author

bbsmartc commented May 3, 2024

oh and please add this to the changelog

changed added

@bw-flagship
Copy link
Collaborator

@bbsmartc did you see my other comment?

@bbsmartc
Copy link
Contributor Author

bbsmartc commented May 3, 2024

@bbsmartc did you see my other comment?

sorry, forgot! in the latest pull request, the log is already modified to

    EasyLocalization.logger('Reset locale to $locale while the platform locale is $_deviceLocale and the fallback locale is $_fallbackLocale');

@bbsmartc bbsmartc closed this May 3, 2024
@bbsmartc bbsmartc reopened this May 3, 2024
@bw-flagship bw-flagship merged commit 0150d7e into aissat:develop May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants