Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strict countryCode problem #690

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

PatrickChrestin
Copy link
Contributor

Fix #674

I added the functionality in that was described and discussed in the issue ticket.
I also added two tests based on the scenario mentioned in the issue ticket.

Feel free to comment or make suggestions.

@bw-flagship please have a look

Copy link
Collaborator

@bw-flagship bw-flagship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I like the change and the tests, there are just some formatting changes that need to be reverted

lib/src/easy_localization_controller.dart Outdated Show resolved Hide resolved
lib/src/easy_localization_controller.dart Outdated Show resolved Hide resolved
test/easy_localization_test.dart Outdated Show resolved Hide resolved
@PatrickChrestin
Copy link
Contributor Author

Perfect. I will take care of them when when I am back home from work.

@PatrickChrestin
Copy link
Contributor Author

The changes to formatting should be all resolved now.

@bw-flagship bw-flagship merged commit 2926e4e into aissat:develop Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strict countryCode problem
2 participants