Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making screenshots appears on the sidebar #716

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

making screenshots appears on the sidebar #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Changelog

### [3.0.8]
- making the screenshots appears on the sidebar
Comment on lines +2 to +3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Update heading level for consistency.

The new entry for version 3.0.8 uses a level 3 heading (###), which is inconsistent with the heading structure of the rest of the document. To maintain consistency and address the static analysis hint, consider changing it to a level 2 heading.

Apply this change to fix the heading level:

-### [3.0.8]
+## [3.0.8]
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
### [3.0.8]
- making the screenshots appears on the sidebar
## [3.0.8]
- making the screenshots appears on the sidebar
🧰 Tools
🪛 Markdownlint

2-2: Expected: h2; Actual: h3
Heading levels should only increment by one level at a time

(MD001, heading-increment)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Improve changelog entry description and fix grammar.

The current description is brief and contains a grammatical error. Consider expanding the description to provide more context about the feature and its benefits. Also, fix the grammatical error in the sentence.

Here's a suggested improvement:

-- making the screenshots appears on the sidebar 
+- Added functionality to display screenshots on the sidebar, improving user experience and navigation.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- making the screenshots appears on the sidebar
- Added functionality to display screenshots on the sidebar, improving user experience and navigation.

### [3.0.7]

- add _supportedLocales in EasyLocalizationController; log and check the deviceLocale when resetLocale;
Expand Down
11 changes: 10 additions & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ homepage: https://github.com/aissat/easy_localization
issue_tracker: https://github.com/aissat/easy_localization/issues
# publish_to: none

version: 3.0.7
version: 3.0.8

environment:
sdk: '>=2.12.0 <4.0.0'
Expand All @@ -25,3 +25,12 @@ dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^2.0.1
screenshots:
- description: The easy localization logo.
path: logo/logo.svg
- description: Arabic Example
path: screenshots/Screenshot_ar.png
- description: English Example
path: screenshots/Screenshot_en.png
- description: Err Example
path: screenshots/Screenshot_err.png