Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename result files from *.mfres.jld2 to *.iesopt.result.jld2 #5

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

daschw
Copy link
Collaborator

@daschw daschw commented Jun 7, 2024

This is still reference to the old MarketFlow name, we should get rid of, right?
Sorry, I did not use conventional commits yet.
Feel free to close if you are already working on this on a local branch.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.33%. Comparing base (b98139b) to head (0ef3ea4).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   36.33%   36.33%           
=======================================
  Files          93       93           
  Lines        3630     3630           
=======================================
  Hits         1319     1319           
  Misses       2311     2311           
Files Coverage Δ
src/results/jld2.jl 6.45% <0.00%> (ø)
src/utils/packing.jl 0.00% <0.00%> (ø)

@daschw daschw changed the title rename result files from *.mfres.yaml to *.iesopt.result.yaml rename result files from *.mfres.jld2 to *.iesopt.result.jld2 Jun 7, 2024
@sstroemer
Copy link
Member

Nice, thanks! This also shows that the codecov diff is misconfigured... having +0.00% on the overall project should be fine, and not require 36.33% on the patch (if it changed something that wasn't covered before). I'll merge and will put that into an issue.

@sstroemer sstroemer merged commit ec9acdb into ait-energy:main Jun 7, 2024
3 of 4 checks passed
@daschw daschw deleted the result-name branch June 7, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants