Skip to content

add(clickhouse): create dictionaries #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 12, 2024
Merged

add(clickhouse): create dictionaries #255

merged 5 commits into from
Jul 12, 2024

Conversation

wojcik-dorota
Copy link
Contributor

@wojcik-dorota wojcik-dorota commented Jun 7, 2024 •
edited
Loading

https://aiven.atlassian.net/browse/DDB-1026

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@wojcik-dorota wojcik-dorota changed the title clickhouse create dictionary add(clickhouse): create dictionaries Jun 7, 2024
@wojcik-dorota wojcik-dorota self-assigned this Jun 7, 2024
@wojcik-dorota wojcik-dorota requested a review from joelynch June 7, 2024 13:34
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jun 7, 2024 •
edited
Loading

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5ec7e3a
Status: ✅  Deploy successful!
Preview URL: https://93864c45.aiven-docs.pages.dev
Branch Preview URL: https://dorota-clickhouse-create-dic.aiven-docs.pages.dev

View logs

@wojcik-dorota wojcik-dorota added the review/awaitingRelease All reviews are completed. label Jun 14, 2024
@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-create-dictionary branch from d02eb7d to 19cf3c6 Compare June 14, 2024 19:22
joelynch
joelynch previously requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@joelynch joelynch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggested changes.

We are getting close to releasing soon!

@wojcik-dorota wojcik-dorota dismissed joelynch’s stale review June 28, 2024 12:22

comments addressed

@wojcik-dorota wojcik-dorota added the review/SME An SME must review the PR. label Jun 28, 2024
@wojcik-dorota wojcik-dorota marked this pull request as ready for review June 28, 2024 12:23
@wojcik-dorota wojcik-dorota requested a review from a team as a code owner June 28, 2024 12:23
joelynch
joelynch approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@joelynch joelynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good and dictionaries are actually in production. But the UI for credentials integration is only being developed starting from Monday 😢.

Perhaps we move all mentions of MySQL and PostgreSQL for now into a separate PR, and merge this?

@wojcik-dorota wojcik-dorota added the review/TW A TW must review the PR. Comes after review/SME. label Jul 11, 2024
@wojcik-dorota
Copy link
Contributor Author

This looks really good and dictionaries are actually in production. But the UI for credentials integration is only being developed starting from Monday 😢.

Perhaps we move all mentions of MySQL and PostgreSQL for now into a separate PR, and merge this?

@joelynch thanks! I commented out mysql and postgresql. Please have a look :-)

@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-create-dictionary branch 2 times, most recently from 4a5e7bb to b845cd2 Compare July 11, 2024 13:15
joelynch
joelynch reviewed Jul 12, 2024
View reviewed changes
@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-create-dictionary branch from b845cd2 to 7c62689 Compare July 12, 2024 09:28
@wojcik-dorota wojcik-dorota removed the review/awaitingRelease All reviews are completed. label Jul 12, 2024
staceysalamon-aiven
staceysalamon-aiven approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@staceysalamon-aiven staceysalamon-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few suggestions added for consideration.

@wojcik-dorota wojcik-dorota removed the review/TW A TW must review the PR. Comes after review/SME. label Jul 12, 2024
@wojcik-dorota wojcik-dorota merged commit 201c8e2 into main Jul 12, 2024
4 checks passed
@wojcik-dorota wojcik-dorota deleted the dorota-clickhouse-create-dictionary branch July 12, 2024 12:00
@wojcik-dorota wojcik-dorota removed the review/SME An SME must review the PR. label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelynch joelynch joelynch approved these changes

@staceysalamon-aiven staceysalamon-aiven staceysalamon-aiven approved these changes

@ArthurAnsquer ArthurAnsquer ArthurAnsquer approved these changes

Assignees

@wojcik-dorota wojcik-dorota

Labels
service/clickhouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wojcik-dorota @joelynch @staceysalamon-aiven @ArthurAnsquer