Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: manage groups role description #660

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Conversation

staceysalamon-aiven
Copy link
Contributor

Describe your changes

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@staceysalamon-aiven staceysalamon-aiven added review/SME An SME must review the PR. review/awaitingRelease All reviews are completed. labels Jan 22, 2025
@staceysalamon-aiven staceysalamon-aiven self-assigned this Jan 22, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2025

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1e72a9b
Status: ✅  Deploy successful!
Preview URL: https://e60a0e0a.aiven-docs.pages.dev
Branch Preview URL: https://staceys-doc-1289.aiven-docs.pages.dev

View logs

@staceysalamon-aiven staceysalamon-aiven marked this pull request as ready for review January 23, 2025 10:49
@staceysalamon-aiven staceysalamon-aiven requested a review from a team as a code owner January 23, 2025 10:49
Signed-off-by: Stacey Salamon <111294980+staceysalamon-aiven@users.noreply.github.com>
Copy link

@rsalevsky rsalevsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is that group members can't be updated when the group has assigned permissions. (Similar to organization:app_users:write ..have not been granted any permissions)

@staceysalamon-aiven
Copy link
Contributor Author

The change is that group members can't be updated when the group has assigned permissions. (Similar to organization:app_users:write ..have not been granted any permissions)

Hey @rsalevsky , sorry, with all the different changes in the permissions and conflicts this one got reverted back to the old text accidentally. I've fixed the group description now. Lmk if you want any other changes. Thanks! 🙏

@staceysalamon-aiven staceysalamon-aiven added review/TW A TW must review the PR. Comes after review/SME. and removed review/SME An SME must review the PR. review/awaitingRelease All reviews are completed. labels Feb 10, 2025
@staceysalamon-aiven staceysalamon-aiven merged commit a021ecd into main Feb 10, 2025
4 checks passed
@staceysalamon-aiven staceysalamon-aiven deleted the staceys-doc-1289 branch February 10, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform review/TW A TW must review the PR. Comes after review/SME.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants