Skip to content

Commit

Permalink
Bump 0.9.10. Remove "debug" setting.
Browse files Browse the repository at this point in the history
  • Loading branch information
aivus committed Dec 1, 2024
1 parent 2dfdb7a commit 4928710
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 49 deletions.
3 changes: 3 additions & 0 deletions .homeychangelog.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,8 @@
},
"0.9.9": {
"en": "Second try to implement encryption mode autodetection"
},
"0.9.10": {
"en": "Remove \"debug\" setting.\n\rPrepare for stable release of the app"
}
}
2 changes: 1 addition & 1 deletion .homeycompose/app.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "com.gree",
"version": "0.9.9",
"version": "0.9.10",
"compatibility": ">=12.0.1",
"sdk": 3,
"brandColor": "#ff732e",
Expand Down
15 changes: 1 addition & 14 deletions app.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"_comment": "This file is generated. Please edit .homeycompose/app.json instead.",
"id": "com.gree",
"version": "0.9.9",
"version": "0.9.10",
"compatibility": ">=12.0.1",
"sdk": 3,
"brandColor": "#ff732e",
Expand Down Expand Up @@ -1468,19 +1468,6 @@
"template": "add_devices"
}
],
"settings": [
{
"id": "enable_debug",
"type": "checkbox",
"value": false,
"label": {
"en": "Debug"
},
"hint": {
"en": "Enable debug in case the application is crashing. It allows developer to investigate the issue"
}
}
],
"images": {
"large": "/drivers/gree_cooper_hunter_hvac/assets/images/large.png",
"small": "/drivers/gree_cooper_hunter_hvac/assets/images/small.png"
Expand Down
15 changes: 1 addition & 14 deletions drivers/gree_cooper_hunter_hvac/device.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ class GreeHVACDevice extends Homey.Device {
}

const deviceData = this.getData();
const settings = this.getSettings();

this.log('[find devices]', 'Finding device with mac:', deviceData.mac);

Expand All @@ -97,8 +96,7 @@ class GreeHVACDevice extends Homey.Device {
this._stopLookingForDevice();

this._client = new HVAC.Client({
// TODO: Permanent debug mode enabled
debug: settings.enable_debug || true,
debug: true,
host: hvac.remoteInfo.address,
pollingInterval: POLLING_INTERVAL,
pollingTimeout: POLLING_TIMEOUT,
Expand Down Expand Up @@ -666,17 +664,6 @@ class GreeHVACDevice extends Homey.Device {
}
}

async onSettings({ oldSettings, newSettings, changedKeys }) {
if (changedKeys.indexOf('enable_debug') > -1) {
this.log('Changing the debug setting from', oldSettings.enable_debug, 'to', newSettings.enable_debug);
if (this._client) {
this._client.setDebug(newSettings.enable_debug);
}
}

return Promise.resolve();
}

reconnect() {
this.log('Reconnecting to the HVAC');
this._markOffline();
Expand Down
13 changes: 0 additions & 13 deletions drivers/gree_cooper_hunter_hvac/driver.compose.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,19 +95,6 @@
"template": "add_devices"
}
],
"settings": [
{
"id": "enable_debug",
"type": "checkbox",
"value": false,
"label": {
"en": "Debug"
},
"hint": {
"en": "Enable debug in case the application is crashing. It allows developer to investigate the issue"
}
}
],
"images": {
"large": "/drivers/gree_cooper_hunter_hvac/assets/images/large.png",
"small": "/drivers/gree_cooper_hunter_hvac/assets/images/small.png"
Expand Down
13 changes: 7 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"homepage": "https://github.com/aivus/com.gree#readme",
"dependencies": {
"gree-hvac-client": "github:aivus/gree-hvac-client#com.gree/public-aes-gcm-poc",
"gree-hvac-client": "^2.1.0",
"homey-log": "^2.1.0"
},
"devDependencies": {
Expand Down

0 comments on commit 4928710

Please sign in to comment.