fix wrong state being passed to indenting functions #3930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, editor.js passes a linestate to the mode checkOutdent, getNextLineIndent, and autoOutdent functions. It also passes the line. The idea is that the function can then reconstruct the tokens of the line using starting state and the line. From other examples I have seen, this is how it is supposed to be used. The problem is, editor.js currently passes the state at the end of the line. This is not very useful, since you cannot get the tokens of a line using the line text and the end state. (at least not reliably)
Issue #, if available:
*Description of changes:
editor.js:1037 is changed from "var lineState = session.getState(cursor.row);" to "var lineState = session.getState(cursor.row - 1);"
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.