Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow and text-wrapping behaviour of tooltip #5275

Closed
wants to merge 1 commit into from

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Aug 2, 2023

Issue #, if available: #5267

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b196806) 87.23% compared to head (9076c15) 87.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5275   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         565      565           
  Lines       45288    45288           
  Branches     6929     6929           
=======================================
  Hits        39508    39508           
  Misses       5780     5780           
Flag Coverage Δ
unittests 87.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/css/editor-css.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkslanc mkslanc marked this pull request as ready for review August 3, 2023 09:25
}

.ace_tooltip * {
text-wrap: wrap;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browser support for text-wrap seems limited, can we get the same behavior in a way with better browser support?

Copy link
Member

@nightwing nightwing Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this rule should be removed and white-space: pre; in the rule before should be changed to pre-wrap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it wouldn't help with cases when non-breakable text is inside pre tag, because modern browsers (at least Chrome is doing that) are providing text-wrap: nowrap; for pre tag by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen-capture.33.webm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkslanc can we have both of the options above combined, so if we are in an older browser white-space: pre-wrap would do the trick?

@InspiredGuy
Copy link
Contributor

Closing this one as it was superseded by #5397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants