-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overflow and text-wrapping behaviour of tooltip #5275
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5275 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 565 565
Lines 45288 45288
Branches 6929 6929
=======================================
Hits 39508 39508
Misses 5780 5780
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
} | ||
|
||
.ace_tooltip * { | ||
text-wrap: wrap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Browser support for text-wrap
seems limited, can we get the same behavior in a way with better browser support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say this rule should be removed and white-space: pre; in the rule before should be changed to pre-wrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately it wouldn't help with cases when non-breakable text is inside pre
tag, because modern browsers (at least Chrome is doing that) are providing text-wrap: nowrap;
for pre
tag by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screen-capture.33.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkslanc can we have both of the options above combined, so if we are in an older browser white-space: pre-wrap
would do the trick?
Closing this one as it was superseded by #5397 |
Issue #, if available: #5267
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.