Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nunjucks mode not break completions #5638

Closed
wants to merge 1 commit into from

Conversation

blaggacao
Copy link

@blaggacao blaggacao commented Sep 8, 2024

Issue #, if available:

image

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (be9e7d4) to head (0ed7fae).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5638   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files         594      594           
  Lines       43395    43396    +1     
  Branches     7170     7170           
=======================================
+ Hits        37742    37743    +1     
  Misses       5653     5653           
Flag Coverage Δ
unittests 86.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blaggacao
Copy link
Author

This isn't going to work as is, and I need jinja anyways, so I concentrate on #5639

@blaggacao blaggacao closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant