-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Added Map to "View Location" on Trekking Page #232
Conversation
@IkkiOcean is attempting to deploy a commit to the ajaynegi45's projects Team on Vercel. A member of the Team first needs to authorize it. |
happy to contribute :) |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @IkkiOcean,
Thank you for your prompt work on this issue. I appreciate your dedication to the project.
I have reviewed your work, and I need some changes.
- How to generate NEXT_PUBLIC_MAPBOX_TOKEN
- Add googlemap and applemap button above close button. So that when user click on it, It will open and show fastest route from there location.
Once again, thank you for your contribution! ❤️
okay. I will make the changes right away in this same pr |
maops.mp4How to make Mapbox token: To generate a Mapbox token, follow these steps:
Your Mapbox token should now be active and ready to use in your application. |
In mapbox it is asking for credit card |
Create button like close. |
@ajaynegi45 yeah most of map services require that for verification. I can send you mine but please keep it hidden as it might exceed the free quota if launched public. |
Share it on LinkedIn |
Means UI part like close button |
sure. accept my request there. |
|
oh okay |
|
@ajaynegi45 done
accept my LinkedIn request, as I cant message you rn. |
Accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @IkkiOcean,
Thank you for your prompt work on this issue. I appreciate your dedication to the project.
I have reviewed your work, and I need some changes.
-
Not Responsive for mobile devices. Make it responsvie for 320px mobile also.
-
When you implement this mentioned Featured Added Filtering Functionality and new locations to Trekking page #225 (review)
Once again, thank you for your contribution! ❤️
@ajaynegi45 made it mobile responsive please check and merge. I am going to raise a new issue for adding more content so please mention the list of new content you want. WhatsApp.Video.2024-10-31.at.05.43.43.mp4 |
I think the located location are not correct in map |
they are starting location of the trek gathered from google |
Overview
This PR introduces a Map component to the trekking page of the Uttarakhand website. The modal allows users to view the location of trekking destinations on a Mapbox map, enhancing user experience by providing an interactive geographical context.
Changes Made
MapModal.js
component that displays a Mapbox map centered on the specified location of the trekking site.MapModal.module.css
to ensure the map occupies the full modal space and maintains responsiveness.MapModal
in theTrekCard
component, enabling users to open the modal and view the location associated with each trek.Implementation Details
Screenshots
map.mp4
Related Issues
Additional Notes
NEXT_PUBLIC_MAPBOX_TOKEN
with your Mapbox access token for the map to function correctly.