Aaron Adler - Completed code and live deployment #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnadlr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nate, please find completed code in this PR.
To run locally:
yarn startTo run tests:
yarn testDeployed live at: https://ajmad.vercel.app/
Notes:
The
SHOW MOREbutton at the bottom of the page is functional. It currently renders 4 additional products on each click. This setting can be modified inApp.jsstate. When all products are rendered, the button is removed from the DOM.The breakpoint from mobile to tablet design is intentionally set to 720px in this demo. Wider breakpoints are best practice when no tablet design has been built. Easy to change with a single variable.
"1-4 of 26 Items" pagination values in the mobile view are dynamic.
All products in the provided API have value
is_quick_ship: false. Therefore, this demo does not render the QuickShip badge dynamically (because then no QuickShip badges would display, per its valuefalse). InProductCard.jsx, you can see sample commented code for dynamic render of the QuickShip badge.PropTypes for each component.
Unit tests for each component.
Thank you
a