Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

DOT4-GRAVITY - Logic adjustment #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DidacSF
Copy link
Contributor

@DidacSF DidacSF commented Jan 4, 2023

Description

Changed the end game logic in ajuna-board pallet, now when a game finishes the board is not removed from storage, only the player references to it.

A new extrinsic clear_board has been added to remove the boards. The change comes from the need of being able to check previously completed games.

Type of changes

  • build: Changes that affect the build system or external dependencies (eg, Cargo, Docker)
  • ci: Changes to CI configuration
  • docs: Changes to documentation only
  • feat: Changes to add a new feature
  • fix: Changes to fix a bug
  • refactor: Changes that do not alter functionality
  • style: Changes to format the code
  • test: Changes to add missing tests or correct existing tests

Checklist

  • Tests for the changes have been added
  • Necessary documentation is added (if appropriate)
  • Formatted with cargo fmt --all
  • Linted with cargo clippy --all-features --all-targets
  • Tested with cargo test --workspace --all-features --all-targets

* Adjust auto clearing logic for finished board games
* Adjusted tests to match logic changes
@DidacSF DidacSF requested a review from darkfriend77 January 4, 2023 11:35
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 89.55% // Head: 88.80% // Decreases project coverage by -0.74% ⚠️

Coverage data is based on head (3d2fa55) compared to base (b430229).
Patch coverage: 63.15% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   89.55%   88.80%   -0.75%     
==========================================
  Files          12       12              
  Lines         680      697      +17     
==========================================
+ Hits          609      619      +10     
- Misses         71       78       +7     
Impacted Files Coverage Δ
pallets/ajuna-board/src/lib.rs 84.61% <63.15%> (-9.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cowboy-bebug

This comment was marked as resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants